eelke/pgLab
1
0
Fork 0
Code Issues 29 Pull requests Projects Releases 1 Packages Wiki Activity Actions

Fix SSL mode combobox did not work properly

Browse source
This commit is contained in:
Eelke Klein 2026-10-26 14:47:19 +01:00
parent 04f525e2e9
commit 0dcee5f76c
No known key found for this signature in database
6 changed files with 228 additions and 34 deletions
Download patch file Download diff file Expand all files Collapse all files

67
tests/pglabtests/tst_SslModeModel.cpp Normal file
View file

@ -0,0 +1,67 @@
#include <gtest/gtest.h>
#include <QComboBox>
#include "ConnectionConfig.h"
#include "PrintTo_Qt.h"
#include "SslModeModel.h"
TEST(SslModeModelTest, SelectedModesKeepTheirTextAndCanonicalValue)
{
SslModeModel model;
QComboBox combo;
combo.setModel(&model);
ASSERT_FALSE(combo.isEditable());
const QStringList modes = {"disable", "allow", "prefer", "require", "verify-ca", "verify-full"};
ASSERT_EQ(combo.count(), modes.size() + 1);
for (const auto &mode : modes) {
SCOPED_TRACE(mode.toStdString());
auto index = combo.findData(mode);
ASSERT_GT(index, 0);
combo.setCurrentIndex(index);
EXPECT_EQ(combo.currentText(), mode);
EXPECT_EQ(combo.currentData().toString(), mode);
ConnectionConfig config;
config.setParameter("sslmode", combo.currentData().toString());
EXPECT_EQ(config.getParameter("sslmode"), mode);
EXPECT_TRUE(config.connectionString().contains("sslmode=" + mode));
QComboBox reopened;
reopened.setModel(&model);
reopened.setCurrentIndex(reopened.findData(config.getParameter("sslmode")));
EXPECT_EQ(reopened.currentText(), mode);
EXPECT_EQ(reopened.currentData().toString(), mode);
}
}
TEST(SslModeModelTest, DefaultClearsAnExplicitMode)
{
SslModeModel model;
QComboBox combo;
combo.setModel(&model);
EXPECT_EQ(combo.currentText(), QStringLiteral("Default"));
EXPECT_EQ(combo.currentData().toString(), QString());
EXPECT_EQ(combo.findData(QString()), 0);
ConnectionConfig config;
config.setParameter("sslmode", "require");
combo.setCurrentIndex(combo.findData(QStringLiteral("require")));
combo.setCurrentIndex(combo.findData(QString()));
config.setParameter("sslmode", combo.currentData().toString());
EXPECT_TRUE(config.getParameter("sslmode").isEmpty());
EXPECT_EQ(config.getParameters().count("sslmode"), 0);
EXPECT_FALSE(config.connectionString().contains("sslmode="));
}
TEST(SslModeModelTest, InvalidIndexesAndChildRowsAreEmpty)
{
SslModeModel model;
EXPECT_FALSE(model.data(QModelIndex()).isValid());
EXPECT_FALSE(model.data(model.index(model.rowCount(), 0)).isValid());
EXPECT_EQ(model.rowCount(model.index(0, 0)), 0);
}