Several fixes of warnings/clang tidy

This commit is contained in:
eelke 2018-12-16 15:38:32 +01:00
parent 2f527a8380
commit 880903db5f
15 changed files with 58 additions and 67 deletions

View file

@ -82,9 +82,7 @@ QString ConnectionList::iniFileName()
}
ConnectionList::ConnectionList()
{
}
ConnectionList::ConnectionList() = default;
size_t ConnectionList::createNew()
{
@ -104,7 +102,7 @@ void ConnectionList::remove(size_t idx, size_t count)
// remove from password save
}
void ConnectionList::deleteFromIni(t_Connections::iterator begin, t_Connections::iterator end)
void ConnectionList::deleteFromIni(const t_Connections::iterator &begin, const t_Connections::iterator &end)
{
QString file_name = iniFileName();
QSettings settings(file_name, QSettings::IniFormat);
@ -118,7 +116,7 @@ void ConnectionList::load()
QString file_name = iniFileName();
QSettings settings(file_name, QSettings::IniFormat);
auto groups = settings.childGroups();
for (auto grp : groups) {
for (auto&& grp : groups) {
if (grp == "c_IniGroupSecurity") {
// Read security settings