eelke/pgLab
1
0
Fork 0
Code Issues 28 Pull requests Projects Releases 1 Packages Wiki Activity Actions

Fix crash when starting to add connection.

Browse source 
Caused by uninitialized variable. Commit contains some minor style fixes also.
This commit is contained in:
eelke 2019-09-02 16:33:13 +02:00
parent 7f88b98cdd
commit bcfd82c27d
5 changed files with 32 additions and 27 deletions
Download patch file Download diff file Expand all files Collapse all files

4
pglab/ConnectionListModel.cpp
View file

@ -366,7 +366,7 @@ std::tuple<int, int> ConnectionTreeModel::findConfig(const QUuid uuid) const
return { group_idx, connection_idx };
}
int ConnectionTreeModel::findGroup(QString name) const
int ConnectionTreeModel::findGroup(const QString &name) const
{
for (int idx = 0; idx < m_groups.size(); ++idx) {
if (m_groups[idx]->name == name) return idx;
@ -374,7 +374,7 @@ int ConnectionTreeModel::findGroup(QString name) const
return -1;
}
std::variant<int, QSqlError> ConnectionTreeModel::addGroup(QString group_name)
std::variant<int, QSqlError> ConnectionTreeModel::addGroup(const QString &group_name)
{
QSqlQuery q(m_db);
q.prepare("INSERT INTO conngroup (gname) VALUES (:name)");