eelke/pgLab
1
0
Fork 0
Code Issues 28 Pull requests Projects Releases 1 Packages Wiki Activity Actions

Make enum DataMeaning an enum class

Browse source
This commit is contained in:
eelke 2024-04-12 06:29:57 +02:00
parent dc97fa63e1
commit db2594a87c
6 changed files with 11 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

6
pglab/CustomDataRole.h
View file

@ -14,9 +14,9 @@ enum class ReferencedType {
}; };
/// ///
enum DataMeaning { enum class DataMeaning {
DataMeaningNormal, Normal,
DataMeaningBytes ///< the value represents bytes pretty print in KiB, MiB, GiB, TiB, PiB, EiB Bytes ///< the value represents bytes pretty print in KiB, MiB, GiB, TiB, PiB, EiB
}; };
enum CustomDataRole { enum CustomDataRole {

2
pglab/catalog/models/BaseTableModel.cpp
View file

@ -24,5 +24,5 @@ QVariant BaseTableModel::data(const QModelIndex &index, int role) const
QVariant BaseTableModel::getDataMeaning(const QModelIndex &) const QVariant BaseTableModel::getDataMeaning(const QModelIndex &) const
{ {
return static_cast<int>(DataMeaningNormal); return static_cast<int>(DataMeaning::Normal);
} }

2
pglab/catalog/models/DatabasesTableModel.cpp
View file

@ -183,7 +183,7 @@ QVariant DatabasesTableModel::getDataMeaning(const QModelIndex &index) const
{ {
if (index.column() == SizeCol) if (index.column() == SizeCol)
{ {
return static_cast<int>(DataMeaningBytes); return static_cast<int>(DataMeaning::Bytes);
} }
return BaseTableModel::getDataMeaning(index); return BaseTableModel::getDataMeaning(index);
} }

4
pglab/catalog/models/IndexModel.cpp
View file

@ -133,9 +133,9 @@ QVariant IndexModel::data(const QModelIndex &index, int role) const
else if (role == CustomDataMeaningRole) { else if (role == CustomDataMeaningRole) {
switch (index.column()) { switch (index.column()) {
case SizeCol: case SizeCol:
return static_cast<int>(DataMeaningBytes); return static_cast<int>(DataMeaning::Bytes);
default: default:
return static_cast<int>(DataMeaningNormal); return static_cast<int>(DataMeaning::Normal);
} }
} }
return v; return v;

4
pglab/catalog/tables/TablesTableModel.cpp
View file

@ -200,9 +200,9 @@ QVariant TablesTableModel::data(const QModelIndex &index, int role) const
case TableSizeCol: case TableSizeCol:
case IndexSizeCol: case IndexSizeCol:
case ToastSizeCol: case ToastSizeCol:
return static_cast<int>(DataMeaningBytes); return static_cast<int>(DataMeaning::Bytes);
default: default:
return static_cast<int>(DataMeaningNormal); return static_cast<int>(DataMeaning::Normal);
} }
} }

4
pglab/util/PgLabItemDelegate.cpp
View file

@ -90,7 +90,7 @@ void PgLabItemDelegate::initStyleOption(QStyleOptionViewItem *option,
value = index.data(CustomDataMeaningRole); value = index.data(CustomDataMeaningRole);
DataMeaning meaning = value.isValid() DataMeaning meaning = value.isValid()
? static_cast<DataMeaning>(value.toInt()) ? static_cast<DataMeaning>(value.toInt())
: DataMeaningNormal; : DataMeaning::Normal;
value = index.data(Qt::DisplayRole); value = index.data(Qt::DisplayRole);
@ -110,7 +110,7 @@ void PgLabItemDelegate::initStyleOption(QStyleOptionViewItem *option,
} }
else { else {
forground_color = GetDefaultColorForType(oid); forground_color = GetDefaultColorForType(oid);
if (meaning == DataMeaningBytes) { if (meaning == DataMeaning::Bytes) {
QString suffix; QString suffix;
auto s = value.toLongLong(); auto s = value.toLongLong();
double val; double val;