eelke/pgLab
1
0
Fork 0
Code Issues 28 Pull requests Projects Releases 1 Packages Wiki Activity Actions

Improve GENERATED support #71

New issue
Closed
opened 2022-01-17 04:44:43 +00:00 by eelke · 18 comments
eelke commented 2022-01-17 04:44:43 +00:00 (Migrated from gitlab.com)
Copy link

Identity

GENERATED { ALWAYS | BY DEFAULT } AS IDENTITY [ ( sequence_options ) ]
  • the sequence options are missing (thought that is fine as long as they are defaults)
  • The column types should be the normal integer types not the serial types
  • crud on table with generated always as identity pkey fails for new rows when BY DEFAULT

Expression

GENERATED ALWAYS AS ( generation_expr ) STORED
  • The generated SQL for the column is incorrect
  • in the column list the column is not shown as generated
  • on a generated always identity column it is possbile for INSERT to override the generated value by specifying "OVERRIDING SYSTEM VALUE". Do we want to support this from CRUD?

Common

  • CRUD always generated columns should be read only
  • CRUD do not send "GENERATED ALWAYS" columns in sql it causes errors
  • generated and stored are not recognized as a keyword, do we need kwlist from newer server version?
## Identity ``` GENERATED { ALWAYS | BY DEFAULT } AS IDENTITY [ ( sequence_options ) ] ``` - [x] the sequence options are missing (thought that is fine as long as they are defaults) - [x] The column types should be the normal integer types not the serial types - [x] crud on table with generated always as identity pkey fails for new rows when BY DEFAULT ## Expression ``` GENERATED ALWAYS AS ( generation_expr ) STORED ``` - [x] The generated SQL for the column is incorrect - [x] in the column list the column is not shown as generated - [ ] on a generated always identity column it is possbile for INSERT to override the generated value by specifying "OVERRIDING SYSTEM VALUE". Do we want to support this from CRUD? ## Common - [x] CRUD always generated columns should be read only - [x] CRUD do not send "GENERATED ALWAYS" columns in sql it causes errors - [x] generated and stored are not recognized as a keyword, do we need kwlist from newer server version?
eelke commented 2022-01-17 04:44:43 +00:00 (Migrated from gitlab.com)
Copy link

assigned to @eelke

assigned to @eelke
eelke commented 2022-09-05 17:55:26 +00:00 (Migrated from gitlab.com)
Copy link

changed the description

changed the description
eelke commented 2022-09-05 18:02:09 +00:00 (Migrated from gitlab.com)
Copy link

changed the description

changed the description
eelke commented 2022-09-05 18:02:34 +00:00 (Migrated from gitlab.com)
Copy link

changed the description

changed the description
eelke commented 2022-09-05 18:03:25 +00:00 (Migrated from gitlab.com)
Copy link

changed the description

changed the description
eelke commented 2022-09-06 04:23:40 +00:00 (Migrated from gitlab.com)
Copy link

changed the description

changed the description
eelke commented 2022-09-06 04:25:32 +00:00 (Migrated from gitlab.com)
Copy link

marked the checklist item The column types should be the normal integer types not the serial types as completed

marked the checklist item **The column types should be the normal integer types not the serial types** as completed
eelke commented 2022-09-06 04:55:20 +00:00 (Migrated from gitlab.com)
Copy link

marked the checklist item in the column list the column is not shown as generated as completed

marked the checklist item **in the column list the column is not shown as generated** as completed
eelke commented 2022-09-06 04:56:38 +00:00 (Migrated from gitlab.com)
Copy link

changed the description

changed the description
eelke commented 2022-09-06 04:58:10 +00:00 (Migrated from gitlab.com)
Copy link

marked the checklist item The generated SQL for the column is incorrect as completed

marked the checklist item **The generated SQL for the column is incorrect** as completed
eelke commented 2022-09-06 05:11:09 +00:00 (Migrated from gitlab.com)
Copy link

marked the checklist item generated and stored are not recognized as a keyword, do we need kwlist from newer server version? as completed

marked the checklist item **generated and stored are not recognized as a keyword, do we need kwlist from newer server version?** as completed
eelke commented 2022-09-06 05:15:04 +00:00 (Migrated from gitlab.com)
Copy link

changed the description

changed the description
eelke commented 2022-09-06 06:28:54 +00:00 (Migrated from gitlab.com)
Copy link

marked the checklist item the sequence options are missing (thought that is fine as long as they are defaults) as completed

marked the checklist item **the sequence options are missing (thought that is fine as long as they are defaults)** as completed
eelke commented 2022-09-06 11:07:36 +00:00 (Migrated from gitlab.com)
Copy link

marked the checklist item crud on table with generated always as identity pkey fails for new rows when BY DEFAULT as completed

marked the checklist item **crud on table with generated always as identity pkey fails for new rows when BY DEFAULT** as completed
eelke commented 2022-09-06 11:07:47 +00:00 (Migrated from gitlab.com)
Copy link

marked the checklist item CRUD always generated columns should be read only as completed

marked the checklist item **CRUD always generated columns should be read only** as completed
eelke commented 2022-09-06 11:07:53 +00:00 (Migrated from gitlab.com)
Copy link

marked the checklist item CRUD do not send "GENERATED ALWAYS" columns in sql it causes errors as completed

marked the checklist item **CRUD do not send "GENERATED ALWAYS" columns in sql it causes errors** as completed
eelke commented 2022-09-06 11:16:54 +00:00 (Migrated from gitlab.com)
Copy link

mentioned in merge request !11

mentioned in merge request !11
eelke commented 2022-09-06 11:17:20 +00:00 (Migrated from gitlab.com)
Copy link

mentioned in commit 50c45426d9

mentioned in commit 50c45426d95edd27ae13c929a67cf8df4e32cd9b
eelke (Migrated from gitlab.com) closed this issue 2022-09-06 11:17:20 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
table-inheritance-tree
antlr
0.2.0
0.1.0
Labels
Clear labels   
bug

   
confirmed

Verified valid bug report

  
Doing

   
feature

   
grouping

   
minor bug

   
Priority

   
Small

   
To Do
No labels
bug
confirmed
Doing
feature
grouping
minor bug
Priority
Small
To Do
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: eelke/pgLab#71
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?